New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy URL command unexpectedly encodes "/" as "%2F" #2939
Comments
I just saw this today after updating Storage Explorer. I can confirm that if I navigate via the Azure Portal (portal.azure.com) to the same container/file and use the "Copy" to clipboard icon - that there are NO URL encoding of slashes to The storage account is being accessed using normal RBAC via Storage Explorer and not a SAS.
|
The URL comes from the Azure Node client library, and we updated to v12 between Storage Explorer 1.12.0 and 1.13.0. We'll need to get in touch with them and find out why the URL behavior is different in v12 than in previous versions. |
Glad it has been identified. It's a big pain. |
Any news on this? |
According to @XiaoningLiu, this was an intentional change on the part of the client SDK. See Azure/azure-sdk-for-js#6886 for reference. @egdedudette We understand the inconvenience this problem has caused, and we're working on a solution. We will need some time to run tests to make sure we don't break anything, because a lot of different parts rely on the code where the URL comes from. @jasongaylord As a workaround, are you able to replace the %2F encodings with slashes manually and get a working URL? |
@craxal For now, that's what I've been doing. When I drop a bunch of blobs, it's somewhat time consuming, but it works for now. |
@jasongaylord Thanks. Just wanted to make sure you had a workaround while we're working on a solution. |
@JasonYeMSFT I didn't notice anything in the build version. Is it closed because its in an Insider build? |
We are making an 1.13.1 release which contains a fix for this issue. It is being propagated to the data centers and should be available soon. |
@jasongaylord you can download 1.13.1 from the "Releases" tab in this repo. We just released the bits there. If you prefer being prompted to upgrade, you will need to wait for at least another day for the bits on Microsoft download center to be propagated to all data centers before you see the prompt. |
Thanks @JasonYeMSFT and @jinglouMSFT! I blogged about it. Should be posted by early morning. Appreciate the quick turnaround. |
FWIW, version 1.13.1 has not yet propagated. I'm going to get it from the releases tab. |
Storage Explorer Version: 1.13.0
Build Number: 20200430.5
Platform/OS: All
Architecture: All
Regression From: 1.12.0
Bug Description
In previous versions of Storage Explorer, Copy URL returned a URL like this:
https://myaccount.blob.core.windows.net/mycontainer/folder/file.html
However, in 1.13.0, COPY URL returns a URL with encoded slashes like this:
https://myaccount.blob.core.window.net/mycontainer/folder%2Ffile.html
For many file types, this isn't an issue. But if I paste the encoded URL into a browser window, some files don't open properly, such as HTML files generated by Adobe Animate CC.
Steps to Reproduce
Expected Experience
The file opens and performs as expected.
Actual Experience
The file opens with errors or missing components.
Additional Context
This bug was originally reported by @egdedudette.
The text was updated successfully, but these errors were encountered: