Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor List #8273

Merged
merged 284 commits into from Jun 30, 2020
Merged

Block Editor List #8273

merged 284 commits into from Jun 30, 2020

Conversation

Shazwazza
Copy link
Contributor

@Shazwazza Shazwazza commented Jun 11, 2020 •
edited by nielslyngsoe

WIP PR for the block editor so we can start the review process.

Test notes:

  • Nested Content in all possible ways, since the storage mechanism of nested content, has been changed a bit.
  • Nested Content with deploy, I(Niels) just want to be sure that we haven't broken something here.
    — Block List Editor, Every possible thing you can think about, it's new so haven't been tested before.
  • Block List Editor inside Block List Editor.
  • Other advanced editors inside Block List Editor.
  • Block List Editor inside advanced editors.
  • Make sure that the above combinations of property editor also transfer nicely with Deploy.

@nielslyngsoe
add style to create-option in itempicker + removing overflow hidden
7b8cd45
@nielslyngsoe
style adjustment
bb3bccb
@nielslyngsoe
clean up of html
596c6b9
@nielslyngsoe
correct sentence to use the number 7
abdf8bc
@nielslyngsoe
correct overlays, so they can use size
35ba840
@nielslyngsoe
numberrange prevalue editor
42ab969
@nielslyngsoe
Merge remote-tracking branch 'origin/v8/dev' into v8/feature/block-ed…
00855dd 
…itor-list
@nielslyngsoe
add confirmRemove overlay
b0e5c4f
@nielslyngsoe
correcting primary btn colors
dd5770b
@nielslyngsoe
move confirmMessage below content of overlay.
946c229
@nielslyngsoe
min max validation for numberrange
1464ddd
@nielslyngsoe
remove comment
b2c2086
@nielslyngsoe
improved actions for block list
74dfe8d
@nielslyngsoe
use file tree for view picker
53d4f5d
@nielslyngsoe
style adjustment to border of creator item in item-picker
aff0164
@nielslyngsoe
vertical align
61c619c
@nielslyngsoe
clean up + validation limit range
23b0a30
@nielslyngsoe
Merge remote-tracking branch 'origin/v8/dev' into v8/feature/block-ed…
0952d9c 
…itor-list
@nielslyngsoe
rename ElementTypes to Blocks
82676ae
@nielslyngsoe
implement block list editor
8ffae1c
@nielslyngsoe
renaming
28adc1b
@nielslyngsoe
use Chrome Headless for unit tests
3779ea8
@nielslyngsoe
test for blockEditorService
4a6484b
@nielslyngsoe
safer code
e30d90a
@nielslyngsoe
block list editor
f43c033
@nielslyngsoe
rename view to overlayView
5b910c1
@nielslyngsoe
block editor work
c72a36c
@nielslyngsoe
Revert "rename view to overlayView"
13aa5cf 
This reverts commit 5b910c1.
@nielslyngsoe
block editor implementation
36dab09
@nielslyngsoe
sync models
fd6d5dc
@warrenbuckley warrenbuckley self-requested a review June 29, 2020 13:35
warrenbuckley
warrenbuckley approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@warrenbuckley warrenbuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked at the last set of changes you have done @nielslyngsoe in your commits and they all look good.

@Shazwazza I had a few minor things mentioned - let me know if you want to deal with them and if we now want to say this is done and merge this into v8/dev and then start making smaller granular PRs?

@stefankip
Copy link

Hi! Don't know if it's okay for me to report a bug already, but here it goes 😇
I have created the datatype for the block list editor and created the first available block.
When I click the square with the word Add inside to add another block, a JS error occurs:

TypeError: Cannot read property 'alias' of undefined
    at umbraco.controllers.js?cdv=123:16027

The error is thrown here: https://github.com/umbraco/Umbraco-CMS/blob/v8/feature/block-editor-list/src/Umbraco.Web.UI.Client/src/views/propertyeditors/blocklist/prevalue/blocklist.blockconfiguration.controller.js#L102

nielslyngsoe and others added 2 commits June 30, 2020 11:08
@nielslyngsoe
use native forEach
7f6ce46
Merge pull request #8336 from benjaminc/v8/feature/block-editor-list
5659cce 
Removal of NestedContent to BlockList migration - due for community project
@warrenbuckley
Copy link
Contributor

Hi! Don't know if it's okay for me to report a bug already, but here it goes 😇
I have created the datatype for the block list editor and created the first available block.
When I click the square with the word Add inside to add another block, a JS error occurs:

TypeError: Cannot read property 'alias' of undefined
    at umbraco.controllers.js?cdv=123:16027

The error is thrown here: https://github.com/umbraco/Umbraco-CMS/blob/v8/feature/block-editor-list/src/Umbraco.Web.UI.Client/src/views/propertyeditors/blocklist/prevalue/blocklist.blockconfiguration.controller.js#L102

@stefankip thanks for being an early tester in this chaos. @nielslyngsoe is looking into this now and will be in a new PR :)

@stefankip
Copy link

@warrenbuckley just checking out all the new block editors on the block (🤣) and noticed this.

@warrenbuckley warrenbuckley merged commit df3dc32 into v8/8.7 Jun 30, 2020
@warrenbuckley warrenbuckley deleted the v8/feature/block-editor-list branch June 30, 2020 09:52
@nielslyngsoe nielslyngsoe mentioned this pull request Jun 30, 2020
Merged
@nielslyngsoe
Copy link
Member

@stefankip thanks for finding this and feel free to report anything.
Fixed in this PR: #8358

@joepvtl
Copy link
Contributor

joepvtl commented Jul 1, 2020 •
edited

Hi, I was playing around with the block editor and found a small issue. If you have a settings model added to a block, then add the block to the page. If you then click on the block settings and when the popup opens click on the content tab, then close the popup and click on the block settings again, you will see that it opens the popup with both tabs enabled.

And I can't add a thumbnail when the image extension is in caps (.PNG).

@ronaldbarendse ronaldbarendse mentioned this pull request Aug 25, 2020
Closed
@nul800sebastiaan nul800sebastiaan mentioned this pull request Dec 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clausjensen clausjensen clausjensen left review comments

@nielslyngsoe nielslyngsoe nielslyngsoe left review comments

@warrenbuckley warrenbuckley warrenbuckley approved these changes

Assignees
No one assigned
Labels
category/notable release/8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Shazwazza @warrenbuckley @stefankip @nielslyngsoe @joepvtl @soreng @clausjensen @nul800sebastiaan @benjaminc